hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17064) Add TaskMonitor#getTasks() variant which accepts type selection
Date Thu, 17 Aug 2017 19:28:03 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16131147#comment-16131147
] 

Hudson commented on HBASE-17064:
--------------------------------

FAILURE: Integrated in Jenkins build HBASE-14070.HLC #233 (See [https://builds.apache.org/job/HBASE-14070.HLC/233/])
HBASE-17064 Add TaskMonitor#getTasks() variant which accepts type (tedyu: rev effd1093b559aeba2bf66a4cf81cd4a0013de184)
* (edit) hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/common/TaskMonitorTmpl.jamon
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/monitoring/TaskMonitor.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/monitoring/TestTaskMonitor.java


> Add TaskMonitor#getTasks() variant which accepts type selection
> ---------------------------------------------------------------
>
>                 Key: HBASE-17064
>                 URL: https://issues.apache.org/jira/browse/HBASE-17064
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: Reid Chan
>            Priority: Minor
>              Labels: ui
>             Fix For: 3.0.0, 2.0.0-alpha-2
>
>         Attachments: HBASE-17064.master.001.patch
>
>
> In TaskMonitorTmpl.jamon :
> {code}
> List<? extends MonitoredTask> tasks = taskMonitor.getTasks();
> Iterator<? extends MonitoredTask> iter = tasks.iterator();
> // apply requested filter
> while (iter.hasNext()) {
>   MonitoredTask t = iter.next();
>   if (filter.equals("general")) {
>     if (t instanceof MonitoredRPCHandler)
>       iter.remove();
> {code}
> This means when user refreshes rs-status page, regardless of the type of filter, we always
traverse and clone MonitoredTask's.
> getTasks() is synchronized :
> {code}
>   public synchronized List<MonitoredTask> getTasks() {
> {code}
> A variant of getTasks() can be added which takes the type of filter so that unnecessary
cloning is avoided.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message