hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Duo Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16324) Remove LegacyScanQueryMatcher
Date Fri, 25 Aug 2017 10:23:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16141457#comment-16141457
] 

Duo Zhang commented on HBASE-16324:
-----------------------------------

It is used for strip compaction. If we remove it then we need to make the below method public

{code}
  private StoreScanner(Store store, ScanInfo scanInfo, OptionalInt maxVersions,
      List<? extends KeyValueScanner> scanners, ScanType scanType, long smallestReadPoint,
      long earliestPutTs, byte[] dropDeletesFromRow, byte[] dropDeletesToRow) throws IOException
{
{code}

It does not make any difference? We still have the same number of public constructors.

Thanks.

> Remove LegacyScanQueryMatcher
> -----------------------------
>
>                 Key: HBASE-16324
>                 URL: https://issues.apache.org/jira/browse/HBASE-16324
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Compaction, regionserver
>    Affects Versions: 3.0.0, 2.0.0-alpha-2
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>            Priority: Critical
>             Fix For: 3.0.0, 2.0.0-alpha-3
>
>         Attachments: HBASE-16324.patch
>
>
> After we eliminate all references to it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message