hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chia-Ping Tsai (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16324) Remove LegacyScanQueryMatcher
Date Fri, 25 Aug 2017 09:43:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16141427#comment-16141427
] 

Chia-Ping Tsai commented on HBASE-16324:
----------------------------------------

Great cleanup!!!

{code}
  /**
   * Used for compactions that drop deletes from a limited range of rows.
   * <p>
   * Opens a scanner across specified StoreFiles.
   * @param store who we scan
   * @param scanners ancillary scanners
   * @param smallestReadPoint the readPoint that we should use for tracking versions
   * @param dropDeletesFromRow The inclusive left bound of the range; can be EMPTY_START_ROW.
   * @param dropDeletesToRow The exclusive right bound of the range; can be EMPTY_END_ROW.
   */
  public StoreScanner(Store store, ScanInfo scanInfo, OptionalInt maxVersions,
{code}
Could we remove this constructor? It is used by Compactor only. The StoreScanner's constructor
is too complicated. The less-variants is better.

> Remove LegacyScanQueryMatcher
> -----------------------------
>
>                 Key: HBASE-16324
>                 URL: https://issues.apache.org/jira/browse/HBASE-16324
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Compaction, regionserver
>    Affects Versions: 3.0.0, 2.0.0-alpha-2
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>            Priority: Critical
>             Fix For: 3.0.0, 2.0.0-alpha-3
>
>         Attachments: HBASE-16324.patch
>
>
> After we eliminate all references to it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message