hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chia-Ping Tsai (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16290) Dump summary of callQueue content; can help debugging
Date Sat, 05 Aug 2017 17:48:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16115474#comment-16115474
] 

Chia-Ping Tsai commented on HBASE-16290:
----------------------------------------

{code}
+
+  /** Retrieves the count of default Rpc queues per Rpc method **/
+  public abstract Map<String, Long> getCallQueueCountsSummary();
+
+  /** Retrieves the size in bytes of default Rpc queues per Rpc method **/
+  public abstract Map<String, Long> getCallQueueSizeSummary();
+
+  /** Retrieves the count of Priority Rpc queues per Rpc method **/
+  public abstract Map<String, Long> getPriorityQueueCountsSummary();
+
+  /** Retrieves the size in bytes of priority Rpc queues per Rpc method **/
+  public abstract Map<String, Long> getPriorityQueueSizeSummary();
+
+  /** Retrieves the count of replication Rpc queues per Rpc method **/
+  public abstract Map<String, Long> getReplicationQueueCountsSummary();
+
+  /** Retrieves the size in bytes of replication Rpc queues per Rpc method **/
+  public abstract Map<String, Long> getReplicationQueueSizeSummary();
{code}
These methods serve only SimpleRpcScheduler. The meaning is not clear for other schedulers.
Can we introduce an new class which carries the queue information? As I see it, we need the
queue name, method name, queue size, and queue count. Also, we need some tests. 

{code}
+  private static void dumpCallQueueSummary(Map<String, Long> summary, PrintWriter out)
{
+    for(String method: summary.keySet()){
+      out.println(method+": "+summary.getOrDefault(method, 0L));
+    }
+  }
{code}
Consider using Map#entrySet

> Dump summary of callQueue content; can help debugging
> -----------------------------------------------------
>
>                 Key: HBASE-16290
>                 URL: https://issues.apache.org/jira/browse/HBASE-16290
>             Project: HBase
>          Issue Type: Bug
>          Components: Operability
>    Affects Versions: 2.0.0
>            Reporter: stack
>            Assignee: Sreeram Venkatasubramanian
>            Priority: Critical
>              Labels: beginner
>             Fix For: 2.0.0
>
>         Attachments: 0001-Dump-call-queue-summaries.patch, DebugDump_screenshot.png,
OldPatch-0001-Dump-Call-Queue-Summary.patch, Sample Summary.txt
>
>
> Being able to get a clue what is in a backedup callQueue could give insight on what is
going on on a jacked server. Just needs to summarize count, sizes, call types. Useful debugging.
In a servlet?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message