hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15069) Unify HFile Writer and Reader creation patterns
Date Thu, 03 Aug 2017 01:42:01 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16112047#comment-16112047
] 

Hadoop QA commented on HBASE-15069:
-----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m  0s{color} | {color:blue}
Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red}  0m  6s{color} | {color:red}
HBASE-15069 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/0.4.0/precommit-patchnames
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-15069 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12782138/hbase-15069.v4b.patch
|
| Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/7897/console |
| Powered by | Apache Yetus 0.4.0   http://yetus.apache.org |


This message was automatically generated.



> Unify HFile Writer and Reader creation patterns
> -----------------------------------------------
>
>                 Key: HBASE-15069
>                 URL: https://issues.apache.org/jira/browse/HBASE-15069
>             Project: HBase
>          Issue Type: Bug
>          Components: HFile
>    Affects Versions: 2.0.0
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>         Attachments: hbase-15069.patch, hbase-15069.v2.patch, hbase-15069.v3.patch, hbase-15069.v4b.patch,
hbase-15069.v4.patch
>
>
> There are a plethora of different static methods sprinkled through out HStoreFile and
HFile, and many tests that have extraneous calls to 'new CacheConfig(conf)' or essentially
extraneous FileSystem arguments threaded through out the code.
> This patch forces all creation to go through HFile Reader and Writer Builders, eliminates
all static Builder constructors, and limits the exposure Reader/Writers .  It also forces
all HFile writer uses outside of the o.a.h.h.io.hfile package to use the StoreFile writers



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message