hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14255) Simplify Cell creation post 1.0
Date Thu, 24 Aug 2017 22:45:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16140872#comment-16140872
] 

stack commented on HBASE-14255:
-------------------------------

CellBuilder sounds good, no? It seems like the first thing a user would go looking for when
they can't find a Constructor on Cell.  I'd think a version that took a value important to
have. I'm not working on this. Its critical though. We should make it easy create Cells.

> Simplify Cell creation post 1.0
> -------------------------------
>
>                 Key: HBASE-14255
>                 URL: https://issues.apache.org/jira/browse/HBASE-14255
>             Project: HBase
>          Issue Type: Improvement
>          Components: Client
>    Affects Versions: 1.0.0, 2.0.0
>            Reporter: Lars George
>            Priority: Critical
>              Labels: beginner
>             Fix For: 2.0.0-alpha-3
>
>
> After the switch to the new Cell based client API, and making KeyValue private (but especially
as soon as DBB backed Cells land) it is rather difficult to create a {{Cell}} instance. I
am using this now:
> {code}
>  @Override
>   public void postGetOp(ObserverContext<RegionCoprocessorEnvironment> e,
>     Get get, List<Cell> results) throws IOException {
>     Put put = new Put(get.getRow());
>     put.addColumn(get.getRow(), FIXED_COLUMN, Bytes.toBytes(counter.get()));
>     CellScanner scanner = put.cellScanner();
>     scanner.advance();
>     Cell cell = scanner.current();
>     LOG.debug("Adding fake cell: " + cell);
>     results.add(cell);
>   }
> {code}
> That is, I have to create a {{Put}} instance to add a cell and then retrieve its instance.
The {{KeyValue}} methods are private now and should not be used. Create a CellBuilder helper?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message