hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chia-Ping Tsai (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-3935) HServerLoad.storefileIndexSizeMB should be changed to storefileIndexSizeKB
Date Sat, 26 Aug 2017 12:03:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16142777#comment-16142777
] 

Chia-Ping Tsai commented on HBASE-3935:
---------------------------------------

{code}
-      storefileSizeMB += rl.getStorefileSizeMB();
+      storefileSizeKB += rl.getStorefileSizeMB()*1024;
{code}
As i see it, using MB is fine for storefile size.

The issue we need to address is "storefile index". BTW, changing the value of load on client
is incorrect way. It seems to me that the following changes are required for this issue.
# We should change the metrics in HRegionServer. see createRegionLoad#createRegionLoad
{code}
  RegionLoad createRegionLoad(final Region r, RegionLoad.Builder regionLoadBldr,
      RegionSpecifier.Builder regionSpecifier) throws IOException {
    byte[] name = r.getRegionInfo().getRegionName();
    int stores = 0;
    int storefiles = 0;
    int storeUncompressedSizeMB = 0;
    int storefileSizeMB = 0;
    int memstoreSizeMB = (int) (r.getMemstoreSize() / 1024 / 1024);
    int storefileIndexSizeMB = 0;
    int rootIndexSizeKB = 0;
    int totalStaticIndexSizeKB = 0;
    int totalStaticBloomSizeKB = 0;
    long totalCompactingKVs = 0;
    long currentCompactedKVs = 0;
    List<Store> storeList = r.getStores();
    stores += storeList.size();
    for (Store store : storeList) {
      storefiles += store.getStorefilesCount();
      storeUncompressedSizeMB += (int) (store.getStoreSizeUncompressed() / 1024 / 1024);
      storefileSizeMB += (int) (store.getStorefilesSize() / 1024 / 1024);
      storefileIndexSizeMB += (int) (store.getStorefilesIndexSize() / 1024 / 1024);
{code}
# the ClusterStatut.proto need to replace *uint32 storefile_index_size_MB* by *uint64 storefile_index_size_KB*
# int ServerLoad#getStorefileIndexSizeMB -> long ServerLoad#getStorefileIndexSizeKB
# ServerLoad.storefileSizeMB -> ServerLoad.storefileSizeKB. Also, the type should be changed
from int to long
# ServerLoad#getStorefileSizeInMB return  ServerLoad#getStorefileIndexSizeKB / 1024

> HServerLoad.storefileIndexSizeMB should be changed to storefileIndexSizeKB
> --------------------------------------------------------------------------
>
>                 Key: HBASE-3935
>                 URL: https://issues.apache.org/jira/browse/HBASE-3935
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: Andy Yang
>         Attachments: HBASE-3935.branch-2.v0.patch, HBASE-3935.branch-2.v1.patch, HBASE-3935.master.v0.patch
>
>
> Related to HBASE-3927, Matt proposed changing HServerLoad.storefileIndexSizeMB to storefileIndexSizeKB
so that user can see the size of small store file index.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message