Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4C115200CC5 for ; Tue, 11 Jul 2017 20:54:03 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 4B188166F53; Tue, 11 Jul 2017 18:54:03 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 924E3166F4E for ; Tue, 11 Jul 2017 20:54:02 +0200 (CEST) Received: (qmail 79598 invoked by uid 500); 11 Jul 2017 18:54:01 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 79587 invoked by uid 99); 11 Jul 2017 18:54:01 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Jul 2017 18:54:01 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 5E6731960F2 for ; Tue, 11 Jul 2017 18:54:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -98.702 X-Spam-Level: X-Spam-Status: No, score=-98.702 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_NUMSUBJECT=0.5, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id Lsb-Q7XB1DRX for ; Tue, 11 Jul 2017 18:54:00 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 60C0662659 for ; Tue, 11 Jul 2017 18:17:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9DE75E0D71 for ; Tue, 11 Jul 2017 18:17:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2539F246C8 for ; Tue, 11 Jul 2017 18:17:00 +0000 (UTC) Date: Tue, 11 Jul 2017 18:17:00 +0000 (UTC) From: "Chia-Ping Tsai (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-18358) Backport HBASE-18099 'FlushSnapshotSubprocedure should wait for concurrent Region#flush() to finish' to branch-1.3 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 11 Jul 2017 18:54:03 -0000 [ https://issues.apache.org/jira/browse/HBASE-18358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16082690#comment-16082690 ] Chia-Ping Tsai commented on HBASE-18358: ---------------------------------------- bq. I think using System.currentTimeMillis() is fine. okay > Backport HBASE-18099 'FlushSnapshotSubprocedure should wait for concurrent Region#flush() to finish' to branch-1.3 > ------------------------------------------------------------------------------------------------------------------ > > Key: HBASE-18358 > URL: https://issues.apache.org/jira/browse/HBASE-18358 > Project: HBase > Issue Type: Bug > Reporter: Ted Yu > Assignee: Ted Yu > Priority: Critical > Attachments: 18358.branch-1.3.patch > > > HBASE-18099 was only integrated to branch-1 and above in consideration of backward compatibility. > This issue is to backport the fix to branch-1.3 and branch-1.2. > Quoting Gary's suggestion from the tail of HBASE-18099 : > {quote} > Sure, don't add the method to Region, just to HRegion, check for an instance of HRegion in FlushSnapshotSubprocedure and cast the instance before calling the method. > {quote} -- This message was sent by Atlassian JIRA (v6.4.14#64029)