Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 40301200CCE for ; Sun, 9 Jul 2017 04:55:06 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 32E7716B6FA; Sun, 9 Jul 2017 02:55:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 7822916B6F9 for ; Sun, 9 Jul 2017 04:55:05 +0200 (CEST) Received: (qmail 48521 invoked by uid 500); 9 Jul 2017 02:55:04 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 48510 invoked by uid 99); 9 Jul 2017 02:55:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 09 Jul 2017 02:55:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id E65E11A0903 for ; Sun, 9 Jul 2017 02:55:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id lHqJJtND0N1X for ; Sun, 9 Jul 2017 02:55:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 79DD75FE54 for ; Sun, 9 Jul 2017 02:55:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B1572E0237 for ; Sun, 9 Jul 2017 02:55:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id E811320D1F for ; Sun, 9 Jul 2017 02:55:00 +0000 (UTC) Date: Sun, 9 Jul 2017 02:55:00 +0000 (UTC) From: "Duo Zhang (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-18348) The implementation of AsyncTableRegionLocator does not follow the javadoc MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sun, 09 Jul 2017 02:55:06 -0000 [ https://issues.apache.org/jira/browse/HBASE-18348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16079425#comment-16079425 ] Duo Zhang commented on HBASE-18348: ----------------------------------- For me, I do not like the 'reload' option. It gives user an impression that this method will modify the cache if reload is true. This makes the implementation a little more complicated as there are more possible races. So I suggest that we change the parameter name from 'reload' to 'bypassCache', or some others words(sorry, poor English) which have the same meaning that we will fetch the HRegionLocation directly from HBase cluster. Thanks. > The implementation of AsyncTableRegionLocator does not follow the javadoc > ------------------------------------------------------------------------- > > Key: HBASE-18348 > URL: https://issues.apache.org/jira/browse/HBASE-18348 > Project: HBase > Issue Type: Bug > Components: asyncclient, Client > Affects Versions: 2.0.0-alpha-1 > Reporter: Duo Zhang > Priority: Critical > Fix For: 2.0.0-alpha-2 > > > The reload parameter is just ignored. > Need to fix this before 2.0.0 release. -- This message was sent by Atlassian JIRA (v6.4.14#64029)