Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 0E7D5200CE0 for ; Thu, 6 Jul 2017 03:41:07 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 0D6F9164FF6; Thu, 6 Jul 2017 01:41:07 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5134D164FFA for ; Thu, 6 Jul 2017 03:41:06 +0200 (CEST) Received: (qmail 7952 invoked by uid 500); 6 Jul 2017 01:41:04 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 7940 invoked by uid 99); 6 Jul 2017 01:41:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Jul 2017 01:41:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 6155618040F for ; Thu, 6 Jul 2017 01:41:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 4ruXDAWxhF2r for ; Thu, 6 Jul 2017 01:41:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id C51A15FE02 for ; Thu, 6 Jul 2017 01:41:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D1C63E0D54 for ; Thu, 6 Jul 2017 01:41:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 42F3624639 for ; Thu, 6 Jul 2017 01:41:00 +0000 (UTC) Date: Thu, 6 Jul 2017 01:41:00 +0000 (UTC) From: "Jingcheng Du (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-18312) Ineffective handling of FileNotFoundException in FileLink$FileLinkInputStream.tryOpen() MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 06 Jul 2017 01:41:07 -0000 [ https://issues.apache.org/jira/browse/HBASE-18312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16075772#comment-16075772 ] Jingcheng Du commented on HBASE-18312: -------------------------------------- +1. > Ineffective handling of FileNotFoundException in FileLink$FileLinkInputStream.tryOpen() > --------------------------------------------------------------------------------------- > > Key: HBASE-18312 > URL: https://issues.apache.org/jira/browse/HBASE-18312 > Project: HBase > Issue Type: Bug > Reporter: Ted Yu > Attachments: 18312.v1.txt, 18312.v2.txt, 18312.v4.txt, 18312.v5.txt, 18312.v6.txt > > > Found the following in region server log: > {code} > 2017-07-03 11:22:04,669 WARN [regionserver/a.b.c.d:16020-shortCompactions-1499094046361] retry.RetryInvocationHandler: Exception while invoking ClientNamenodeProtocolTranslatorPB.getBlockLocations over e.f.g.h:8020. Not retrying because try once and fail. > org.apache.hadoop.ipc.RemoteException(java.io.FileNotFoundException): File does not exist: /hbase/data/default/X/4d61af9d1cbcc5fe2a5cbddbfc92fe7e/ K/47222a9cbd294f499f49de92ecf330ee > at org.apache.hadoop.hdfs.server.namenode.INodeFile.valueOf(INodeFile.java:71) > at org.apache.hadoop.hdfs.server.namenode.INodeFile.valueOf(INodeFile.java:61) > ... > at org.apache.hadoop.hbase.io.FileLink$FileLinkInputStream.tryOpen(FileLink.java:291) > at org.apache.hadoop.hbase.io.FileLink$FileLinkInputStream.(FileLink.java:122) > at org.apache.hadoop.hbase.io.FileLink$FileLinkInputStream.(FileLink.java:113) > at org.apache.hadoop.hbase.io.FileLink.open(FileLink.java:404) > at org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.(FSDataInputStreamWrapper.java:98) > at org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.(FSDataInputStreamWrapper.java:83) > {code} > Here is related code: > {code} > private FSDataInputStream tryOpen() throws IOException { > for (Path path: fileLink.getLocations()) { > ... > } catch (FileNotFoundException e) { > // Try another file location > } > {code} > The intention is to try possible locations for the linked file. > However, RemoteException was the exception encountered. This makes the above catch clause ineffective. -- This message was sent by Atlassian JIRA (v6.4.14#64029)