Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id ACEEE200CEC for ; Mon, 31 Jul 2017 19:10:05 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id AB8661658E8; Mon, 31 Jul 2017 17:10:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id F30791658E6 for ; Mon, 31 Jul 2017 19:10:04 +0200 (CEST) Received: (qmail 68933 invoked by uid 500); 31 Jul 2017 17:10:04 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 68832 invoked by uid 99); 31 Jul 2017 17:10:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 31 Jul 2017 17:10:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id ACD47180582 for ; Mon, 31 Jul 2017 17:10:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id dgdJEkI-h6il for ; Mon, 31 Jul 2017 17:10:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 4C6CB5FC3A for ; Mon, 31 Jul 2017 17:10:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 418F1E0E26 for ; Mon, 31 Jul 2017 17:10:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 6A9A12465E for ; Mon, 31 Jul 2017 17:10:00 +0000 (UTC) Date: Mon, 31 Jul 2017 17:10:00 +0000 (UTC) From: "stack (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-17056) Remove checked in PB generated files MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 31 Jul 2017 17:10:05 -0000 [ https://issues.apache.org/jira/browse/HBASE-17056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16107612#comment-16107612 ] stack commented on HBASE-17056: ------------------------------- Playing around with the maven-replacer-plugin so generated files have o.a.h.h.shaded.com.google in them rather than just com.google... Current issue is that the replacement happens each time I do a mvn install so double replaces... And then the replacer regex doesn't seem to work as expected. Fun. > Remove checked in PB generated files > ------------------------------------- > > Key: HBASE-17056 > URL: https://issues.apache.org/jira/browse/HBASE-17056 > Project: HBase > Issue Type: Bug > Affects Versions: 2.0.0 > Reporter: Enis Soztutar > Assignee: stack > Priority: Critical > Fix For: 2.0.0 > > Attachments: 0002-HBASE-17056-Remove-checked-in-PB-generated-files.patch, HBASE-17056.master.001.patch, HBASE-17056.master.002.patch, HBASE-17056.master.003.patch, HBASE-17056.master.004.patch, HBASE-17056.master.005.patch > > > Now that we have the new PB maven plugin, there is no need to have the PB files checked in to the repo. The reason we did that was to ease up developer env setup. -- This message was sent by Atlassian JIRA (v6.4.14#64029)