Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Sun, 2 Jul 2017 00:36:00 +0000 (UTC)
From: "Hudson (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12732824.1407502170000.154079.1498955760112@Atlassian.JIRA>
In-Reply-To: <JIRA.12732824.1407502170000@Atlassian.JIRA>
References: <JIRA.12732824.1407502170000@Atlassian.JIRA> <JIRA.12732824.1407502170289@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HBASE-11707) Using Map instead of list in
 FailedServers of RpcClient
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sun, 02 Jul 2017 00:36:06 -0000


    [ https://issues.apache.org/jira/browse/HBASE-11707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16071456#comment-16071456 ] 

Hudson commented on HBASE-11707:
--------------------------------

SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #3294 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3294/])
HBASE-11707 Using Map instead of list in FailedServers of RpcClient (Liu (stack: rev f1b97a6aa0206636cdfeafaad70af914e91979d3)
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/FailedServers.java


> Using Map instead of list in FailedServers of RpcClient
> -------------------------------------------------------
>
>                 Key: HBASE-11707
>                 URL: https://issues.apache.org/jira/browse/HBASE-11707
>             Project: HBase
>          Issue Type: Improvement
>          Components: Client
>            Reporter: Liu Shaohui
>            Assignee: Liu Shaohui
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: HBASE-11707.master.001.patch, HBASE-11707-trunk-v1.diff, HBASE-11707-trunk-v2.diff
>
>
> Currently, FailedServers uses a list to record the black list of servers and iterate the list to check if a server is in list. It's not efficient when the list is very large. And the list is not thread safe for the add and iteration operations.
> RpcClient.java#175
> {code}
>       // iterate, looking for the search entry and cleaning expired entries
>       Iterator<Pair<Long, String>> it = failedServers.iterator();
>       while (it.hasNext()) {
>         Pair<Long, String> cur = it.next();
>          if (cur.getFirst() < now) {
>           it.remove();
>         } else {
>           if (lookup.equals(cur.getSecond())) {
>             return true;
>           }
>         }
> {code}
> A simple change is to change this list to ConcurrentHashMap.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)