hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18473) VC.listLabels() erroneously closes any connection
Date Sun, 30 Jul 2017 10:25:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16106424#comment-16106424
] 

Hudson commented on HBASE-18473:
--------------------------------

FAILURE: Integrated in Jenkins build HBase-1.3-JDK7 #210 (See [https://builds.apache.org/job/HBase-1.3-JDK7/210/])
HBASE-18473 VC.listLabels() erroneously closes any connection. (anoopsamjohn: rev 3e450f7a077632902fafa43dc7d9afa462125060)
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityClient.java


> VC.listLabels() erroneously closes any connection
> -------------------------------------------------
>
>                 Key: HBASE-18473
>                 URL: https://issues.apache.org/jira/browse/HBASE-18473
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 1.2.0, 2.0.0-alpha-1
>            Reporter: Lars George
>            Assignee: Anoop Sam John
>              Labels: beginner
>             Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-2
>
>         Attachments: HBASE-18473.patch
>
>
> In HBASE-13358 the {{VisibilityClient.listLabels()}} was amended to take in a connection
from the caller, which totally makes sense. But the patch forgot to remove the unconditional
call to {{connection.close()}} in the {{finally}} block:
> {code}
>     finally {
>       if (table != null) {
>         table.close();
>       }
>       if (connection != null) {
>         connection.close();
>       }
>     }
> {code}
> Remove the second {{if}} completely.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message