hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18446) Mark StoreFileScanner as IA.Private
Date Thu, 27 Jul 2017 16:50:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16103480#comment-16103480
] 

Andrew Purtell commented on HBASE-18446:
----------------------------------------

[~Apache9] Phoenix uses StoreFile and StoreFileReader in the local index implementation.

phoenix-core/src/main/java/org/apache/hadoop/hbase/regionserver/IndexHalfStoreFileReaderGenerator.java
phoenix-core/src/main/java/org/apache/hadoop/hbase/regionserver/LocalIndexStoreFileScanner.java
phoenix-core/src/main/java/org/apache/hadoop/hbase/regionserver/IndexHalfStoreFileReader.java
phoenix-core/src/main/java/org/apache/phoenix/util/RepairUtil.java

So I think we need to expose these as LimitedPrivate. We could do more and make these into
reduced and supportable interfaces like we did when introducing the Region interface. 

There are other references, but they are just treating the types as opaque, passing them from
a CP hook to a delegate method etc. 

[~rajeshbabu]
[~samarthjain]


> Mark StoreFileScanner as IA.Private
> -----------------------------------
>
>                 Key: HBASE-18446
>                 URL: https://issues.apache.org/jira/browse/HBASE-18446
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Coprocessors
>            Reporter: Duo Zhang
>             Fix For: 2.0.0, 3.0.0, 2.0.0-alpha-2
>
>
> Do not see any reason why it is marked as IA.LimitedPrivate. It is not referenced in
any CPs.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message