hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Misty Stanley-Jones (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18430) Typo in "contributing to documentation" page
Date Fri, 21 Jul 2017 20:46:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16096826#comment-16096826
] 

Misty Stanley-Jones commented on HBASE-18430:
---------------------------------------------

No, {{-s}} is not cryptographic signing. You use {{-S}} for that. Gotta love {{git}}. I didn't
realize that about the subject. I don't recall seeing it in other patches created using {{git
format-patch}}, but when I look back at my old patches it is there. Sorry about that!

The {{-s}} is useful for committers who are committing others' patches. It adds a sign-off
line for you beneath the sign-off line for the contributor. It's not a current requirement,
and I forget to do it half the time myself.

> Typo in "contributing to documentation" page
> --------------------------------------------
>
>                 Key: HBASE-18430
>                 URL: https://issues.apache.org/jira/browse/HBASE-18430
>             Project: HBase
>          Issue Type: Bug
>          Components: documentation
>            Reporter: Coral
>            Assignee: Coral
>         Attachments: HBASE-18430.patch
>
>
> Be sure to set the component to Documentation in addition any other involved components.
> Missing "to." Should be: 
> Be sure to set the component to Documentation in addition *to* any other involved components.
> http://hbase.apache.org/book.html#appendix_contributing_to_documentation



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message