hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiaobing Zhou (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18407) [C++] make Configuration::Set/GetBool work for both true/false and 1/0
Date Wed, 19 Jul 2017 21:34:01 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16093818#comment-16093818
] 

Xiaobing Zhou commented on HBASE-18407:
---------------------------------------

repost v0, following the patch naming convention to let it being applied to feature branch.

> [C++] make Configuration::Set/GetBool work for both true/false and 1/0
> ----------------------------------------------------------------------
>
>                 Key: HBASE-18407
>                 URL: https://issues.apache.org/jira/browse/HBASE-18407
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Xiaobing Zhou
>            Assignee: Xiaobing Zhou
>         Attachments: HBASE-18407.000.patch, HBASE-18407-HBASE-14850.000.patch
>
>
> Configuration::SetBool internally converts true/false to 1/0 using boost::lexical_cast<std::string>(value),
this results in runtime exception with 'Unexpected value found while conversion to bool.'
in Configuration::GetBool since it only recognizes "true" or "false" as string representation
of true or false. 1/0 should be considered in the check in GetBool.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message