hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18407) [C++] make Configuration::Set/GetBool work for both true/false and 1/0
Date Wed, 19 Jul 2017 21:29:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16093812#comment-16093812
] 

Hadoop QA commented on HBASE-18407:
-----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m  0s{color} | {color:blue}
Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red}  0m  5s{color} | {color:red}
HBASE-18407 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/0.4.0/precommit-patchnames
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-18407 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12878047/HBASE-18407.000.patch
|
| Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/7723/console |
| Powered by | Apache Yetus 0.4.0   http://yetus.apache.org |


This message was automatically generated.



> [C++] make Configuration::Set/GetBool work for both true/false and 1/0
> ----------------------------------------------------------------------
>
>                 Key: HBASE-18407
>                 URL: https://issues.apache.org/jira/browse/HBASE-18407
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Xiaobing Zhou
>            Assignee: Xiaobing Zhou
>         Attachments: HBASE-18407.000.patch
>
>
> Configuration::SetBool internally converts true/false to 1/0 using boost::lexical_cast<std::string>(value),
this results in runtime exception with 'Unexpected value found while conversion to bool.'
in Configuration::GetBool since it only recognizes "true" or "false" as string representation
of true or false. 1/0 should be considered in the check in GetBool.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message