hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18402) Thrift2 should support DeleteFamilyVersion type
Date Wed, 19 Jul 2017 15:39:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16093287#comment-16093287
] 

Ted Yu commented on HBASE-18402:
--------------------------------

For ThriftUtilities, this line (277) is not governed by in.isSetDeleteType() :
{code}
              out.addColumn(column.getFamily(), column.getQualifier(), column.getTimestamp());
{code}
Looks like the above is removed.

Please keep non-delete logic.

> Thrift2 should support  DeleteFamilyVersion type
> ------------------------------------------------
>
>                 Key: HBASE-18402
>                 URL: https://issues.apache.org/jira/browse/HBASE-18402
>             Project: HBase
>          Issue Type: Bug
>          Components: Thrift
>    Affects Versions: 2.0.0-alpha-1
>            Reporter: Zheng Hu
>            Assignee: Zheng Hu
>         Attachments: HBASE-18402.v1.patch
>
>
> Currently,  our thrift2 only support two delete types, Actually, there are four delete
types.and  we should support the other delete type:  DeleteFamily and DeleteFamilyVersion.

> {code}
> /**
>  * Specify type of delete:
>  *  - DELETE_COLUMN means exactly one version will be removed,
>  *  - DELETE_COLUMNS means previous versions will also be removed.
>  */
> enum TDeleteType {
>   DELETE_COLUMN = 0,
>   DELETE_COLUMNS = 1
> }
> {code} 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message