hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiaobing Zhou (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18400) [C++] ConnectionId Equals/Hash should consider service_name
Date Tue, 18 Jul 2017 17:06:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16091820#comment-16091820

Xiaobing Zhou commented on HBASE-18400:

Hi [~tedyu], thanks for your review.

The last 8 lines are just using scope to avoid duplicate variables (e.g. remote_id) declarations,
but call GetConnection four times so that ConnectionFactory::Connect and ConnectionFactory::MakeBootstrap
are invoked only two times, which is the semantics of connection pool.

> [C++] ConnectionId Equals/Hash should consider service_name
> -----------------------------------------------------------
>                 Key: HBASE-18400
>                 URL: https://issues.apache.org/jira/browse/HBASE-18400
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Xiaobing Zhou
>            Assignee: Xiaobing Zhou
>         Attachments: HBASE-18400.000.patch
> Currently only security::User, host and port are taken into account in the implementation
of ConnectionIdEquals and ConnectionIdHash. It makes sense to allocate dedicated RPC connection
for a specific service, so service_name should be added to implementation;

This message was sent by Atlassian JIRA

View raw message