hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Balazs Meszaros (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18367) Reduce ProcedureInfo usage
Date Tue, 18 Jul 2017 11:56:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16091461#comment-16091461
] 

Balazs Meszaros commented on HBASE-18367:
-----------------------------------------

Thanks for the review [~stack]!

I have also uploaded my patch to RB: https://reviews.apache.org/r/60796/

I followed your advices. I created FailedProcedure because previously {{setFailureResultForNonce()}}
created a ProcedureInfo object and set its fields according to the failure. It is not possible
to create a Procedure object with these fields, because these fields are private in Procedure
and there are not any public setters for them. So we have to create a new class unless we
have a reference to a Procedure object.

> Reduce ProcedureInfo usage
> --------------------------
>
>                 Key: HBASE-18367
>                 URL: https://issues.apache.org/jira/browse/HBASE-18367
>             Project: HBase
>          Issue Type: Sub-task
>          Components: master, proc-v2
>            Reporter: Balazs Meszaros
>            Assignee: Balazs Meszaros
>             Fix For: 2.0.0, 3.0.0
>
>         Attachments: HBASE-18367.001.patch, HBASE-18367.002.patch, HBASE-18367.003.patch
>
>
> If we want to replace ProcedureInfo objects with jsons (HBASE-18106) we have to reduce
ProcedureInfo usage. Currently it is used several places in the code where it could be replaced
with Procedure (e.g. ProcedureExecutor). We should use ProcedureInfo only for the communication
before removing it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message