hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18327) redo test-patch personality 'hadoopcheck' to better account for feature branches
Date Sat, 08 Jul 2017 08:20:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16079039#comment-16079039
] 

Hudson commented on HBASE-18327:
--------------------------------

FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3336 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3336/])
HBASE-18327 redo test-patch personality 'hadoopcheck' to better account (busbey: rev 30d06dfe3aa29ec0acc0e0ba0aa1fd21919ce64e)
* (edit) dev-support/hbase-personality.sh


> redo test-patch personality 'hadoopcheck' to better account for feature branches
> --------------------------------------------------------------------------------
>
>                 Key: HBASE-18327
>                 URL: https://issues.apache.org/jira/browse/HBASE-18327
>             Project: HBase
>          Issue Type: Improvement
>          Components: build, test
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>            Priority: Minor
>             Fix For: 3.0.0
>
>         Attachments: HBASE-18327.0.patch, HBASE-18327.1.patch, HBASE-18327.2.patch
>
>
> right now our 'which hadoop checks do we need' check looks like this:
> {code}
>   if [[ "${PATCH_BRANCH}" = "master" ]]; then
>     hbase_hadoop2_versions=${HBASE_MASTER_HADOOP2_VERSIONS}
>     hbase_hadoop3_versions=${HBASE_MASTER_HADOOP3_VERSIONS}
>   elif [[ ${PATCH_BRANCH} = branch-2* ]]; then
>     hbase_hadoop2_versions=${HBASE_BRANCH2_HADOOP2_VERSIONS}
>     hbase_hadoop3_versions=${HBASE_BRANCH2_HADOOP3_VERSIONS}
>   else
>     hbase_hadoop2_versions=${HBASE_HADOOP2_VERSIONS}
>     hbase_hadoop3_versions=${HBASE_HADOOP3_VERSIONS}
>   fi
> {code}
> the check is basically "if master do this, if like branch-2 do that, otherwise behave
like branch-1".
> we often have feature branches that thus end up being treated like branch-1, even though
those branches should all be based off of master. (since we follow a master-first development
approach.)
> we should redo this check so it's "if branch-1 do this, if branch-2 do that, otherwise
behave like master"



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message