hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Drob (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18324) [hbase-thirdparty] Tooling to prevent commits that mistakenly make use of unshaded protobuf/guava/etc.
Date Wed, 05 Jul 2017 23:02:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16075585#comment-16075585
] 

Mike Drob commented on HBASE-18324:
-----------------------------------

[~apurtell] - that looks good. do we still have to implement custom rules for it? I didn't
see anything in the default ruleset to ban certain imports.

> [hbase-thirdparty] Tooling to prevent commits that mistakenly make use of unshaded protobuf/guava/etc.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-18324
>                 URL: https://issues.apache.org/jira/browse/HBASE-18324
>             Project: HBase
>          Issue Type: Bug
>            Reporter: stack
>
> Chatting w/ [~mdrob], he brought up the question of what if a dev makes use of unshaded
protobuf or guava? Afterall, the old jars (pb2.5 and hadoops guava12.0 or whatever) are still
on the CLASSPATH because upstream depends on them.
> We could add a check as part of prebuild. It would complain if use of com.google instead
of org.apache.hadoop.hbase.shaded.com.google. But even then, there are cases where com.google
is legit (coprocessor endpoints) so it would have to let these pass.
> TODO.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message