hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yi Liang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18107) [AMv2] Rename DispatchMergingRegionsRequest & DispatchMergingRegions
Date Wed, 05 Jul 2017 22:30:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16075546#comment-16075546

Yi Liang commented on HBASE-18107:

Hi [~stack], below is my finds about this DispatchMergingRegions
here is the 2 execute paths of merge in two branches
In branch-1.2:
-> MasterKeepAliveConnection.dispatchMergingRegions
-> MasterRpcServices.dispatchMergingRegions
-> HMaster.dispatchMergingRegions
-> DispatchMergingRegionHandler
In branch master:
-> MasterKeepAliveConnection.mergeTableRegions
-> MasterRpcServices.mergeTableRegions
-> HMaster.mergeRegions 
-> MasterProcedureUtil.submitProcedure 

It seems that [~syuanjiang]  have replaced  dispatchMergingRegions with MergeTableRegionsProcedure,
followed by the history of merge procedure:

In HBASE-14552,The DispatchMergingRegionHandler has been replaced with DispatchMergingRegionsProcedure

In HBASE-16119 DispatchMergingRegionsProcedure has been replaced with MergeTableRegionsProcedure

In HBASE-17470 DispatchMergingRegionsProcedure has been removed

In HBase-14614, it seems that DispatchMergingRegionsProcedure added back again

So from my point of view, we need to remove DispatchMergingRegionsProcedure
i.e we need to remove the path 2 of Merge Regions as I mentioned in HBASE-18105

> [AMv2] Rename DispatchMergingRegionsRequest & DispatchMergingRegions
> --------------------------------------------------------------------
>                 Key: HBASE-18107
>                 URL: https://issues.apache.org/jira/browse/HBASE-18107
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Region Assignment
>    Affects Versions: 2.0.0
>            Reporter: stack
>             Fix For: 2.0.0
> They don't align with how we have named the Split equivalents; i.e. SplitRegion (so should
be MergeRegion...). They probably have these awkward names because the obvious slots are occupied...
so this may not be fixable but filing issue anyways.

This message was sent by Atlassian JIRA

View raw message