hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17436) Add facility to provide more information for Other Regions seen on Master UI
Date Sun, 02 Jul 2017 16:00:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16071697#comment-16071697
] 

Ted Yu commented on HBASE-17436:
--------------------------------

{code}
+public class RegionStateJsonServlet extends HttpServlet {
{code}
Add javadoc explaining the purpose for the servlet. Add annotation for audience.
{code}
+    if (!HttpServer.hasAdministratorAccess(getServletContext(), request, response))
+      return;
{code}
Either move the 'return' to same line as if or, enclose with curly braces.
{code}
+    // querying for a certain table
{code}
Move the above comment into if block below.
{code}
+              if (entry1 == null || entry1.getValue()==null) {
{code}
Did you mean to call .getKey above (value is of type RegionLoad which is not used in the patch)
?
{code}
+   state = regionState.toString();
+   break;
+ }
{code}
Adjust indentation.

If display layout changes, please attach some screenshots.

Thanks

> Add facility to provide more information for Other Regions seen on Master UI
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-17436
>                 URL: https://issues.apache.org/jira/browse/HBASE-17436
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: Janos Gub
>              Labels: ui, usability
>             Fix For: 2.0.0
>
>         Attachments: HBASE-17436.patch, HBASE-17436-v2.patch, HBASE-17436-v5.patch, HBASE-17436-v6.patch,
HBASE-17436-v6.patch, HBASE-17779-v3.patch, HBASE-17779-v4.patch, initial.patch, Screen Shot
2017-04-24 at 8.43.31 PM.png, Screen Shot 2017-04-26 at 4.39.49 PM.png
>
>
> [~rpednekar] and I were looking at a case where the count displayed under Other Regions
was high (~1200).
> Since the table page just maintains a count instead of List of region names, it is very
difficult for user to determine which regions belong to this category.
> We should provide facility to provide more details for this category (LOG, JMX, etc).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message