hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17056) Remove checked in PB generated files
Date Mon, 31 Jul 2017 17:44:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16107673#comment-16107673
] 

stack commented on HBASE-17056:
-------------------------------

The maven-replacer-plugin is old. Its in google code archive. Here some other fellow fixed
up the usage page https://github.com/beiliubei/maven-replacer-plugin/wiki/Usage-Guide

Every mvn install was doing an interpolation.  Hackery w/ regex made it so we only do replacement
once. The replacer needs to work w/ the protoc plugin.  There is probably a better way but
.006 seems to be working. It at least allows the old running of a single unit test which was
failing w/ old patch (reported by [~zghaobac]).

> Remove checked in PB generated files 
> -------------------------------------
>
>                 Key: HBASE-17056
>                 URL: https://issues.apache.org/jira/browse/HBASE-17056
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.0
>            Reporter: Enis Soztutar
>            Assignee: stack
>            Priority: Critical
>             Fix For: 2.0.0
>
>         Attachments: 0002-HBASE-17056-Remove-checked-in-PB-generated-files.patch, HBASE-17056.master.001.patch,
HBASE-17056.master.002.patch, HBASE-17056.master.003.patch, HBASE-17056.master.004.patch,
HBASE-17056.master.005.patch
>
>
> Now that we have the new PB maven plugin, there is no need to have the PB files checked
in to the repo. The reason we did that was to ease up developer env setup. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message