hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-17056) Remove checked in PB generated files
Date Thu, 06 Jul 2017 04:37:02 GMT

     [ https://issues.apache.org/jira/browse/HBASE-17056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

stack updated HBASE-17056:
--------------------------
    Release Note: 
Purge all checked in generated protobuf files (30MB). Generate protobuf files inline with
the build. Remove checked-in and patched protobuf. Get it from new hbase-thirdparty instead.

Side-effect: Our protobuf went from 3.1.0 to 3.3.1.

Build does not take noticeably longer (still about 2.5 minutes to do a mvn clean install -DskipTests).

IDEs will probably require a mvn build first else they'll complain about missing (generated)
files.

  was:
Purge all checked in generated protobuf files. Generate protobuf files inline with the build.
Remove checked-in and patched protobuf. Get it from new hbase-thirdparty instead.

Side-effect: Our protobuf went from 3.1.0 to 3.3.1.

Build does not take noticeably longer (still about 2.5 minutes to do a mvn clean install -DskipTests).

IDEs will probably require a mvn build first else they'll complain about missing (generated)
files.


> Remove checked in PB generated files 
> -------------------------------------
>
>                 Key: HBASE-17056
>                 URL: https://issues.apache.org/jira/browse/HBASE-17056
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.0
>            Reporter: Enis Soztutar
>            Assignee: stack
>             Fix For: 2.0.0
>
>         Attachments: 0002-HBASE-17056-Remove-checked-in-PB-generated-files.patch, HBASE-17056.master.001.patch,
HBASE-17056.master.002.patch, HBASE-17056.master.003.patch
>
>
> Now that we have the new PB maven plugin, there is no need to have the PB files checked
in to the repo. The reason we did that was to ease up developer env setup. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message