hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17056) Remove checked in PB generated files
Date Wed, 05 Jul 2017 22:12:01 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16075514#comment-16075514
] 

stack commented on HBASE-17056:
-------------------------------

bq. This is no longer accurate, yes? Same applied to hbase-examples.

It is in that now the files are generated inline with the build. Before you had to generate
them via a special step done pre-build.

On the poms, yeah, sorry, they were wonky so did a format. Pom changes are just adding dependency
on hbase-thirdparty and narrowing guava includes by adding excludes to hadoop-* artifacts.

Thanks for the review [~mdrob]

Let me get a clean run via hadoop qa.

> Remove checked in PB generated files 
> -------------------------------------
>
>                 Key: HBASE-17056
>                 URL: https://issues.apache.org/jira/browse/HBASE-17056
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.0
>            Reporter: Enis Soztutar
>            Assignee: stack
>             Fix For: 2.0.0
>
>         Attachments: 0002-HBASE-17056-Remove-checked-in-PB-generated-files.patch, HBASE-17056.master.001.patch,
HBASE-17056.master.002.patch
>
>
> Now that we have the new PB maven plugin, there is no need to have the PB files checked
in to the repo. The reason we did that was to ease up developer env setup. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message