hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Drob (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17056) Remove checked in PB generated files
Date Wed, 05 Jul 2017 19:56:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16075308#comment-16075308
] 

Mike Drob commented on HBASE-17056:
-----------------------------------

{noformat:title=hbase-endpoint/README.txt}
+Generation of java files from protobuf .proto files included here is done as
+part of the build.
{noformat}
This is no longer accurate, yes? Same applied to hbase-examples.

{{hbase-endpoint/pom.xml}} - Is this mostly whitespace changes? Hard to review.

I like deleted source!





> Remove checked in PB generated files 
> -------------------------------------
>
>                 Key: HBASE-17056
>                 URL: https://issues.apache.org/jira/browse/HBASE-17056
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.0
>            Reporter: Enis Soztutar
>            Assignee: stack
>             Fix For: 2.0.0
>
>         Attachments: 0002-HBASE-17056-Remove-checked-in-PB-generated-files.patch, HBASE-17056.master.001.patch,
HBASE-17056.master.002.patch
>
>
> Now that we have the new PB maven plugin, there is no need to have the PB files checked
in to the repo. The reason we did that was to ease up developer env setup. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message