Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9E7F5200CB7 for ; Fri, 30 Jun 2017 19:17:03 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 9C57C160BF9; Fri, 30 Jun 2017 17:17:03 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id ECACC160BEB for ; Fri, 30 Jun 2017 19:17:02 +0200 (CEST) Received: (qmail 85185 invoked by uid 500); 30 Jun 2017 17:17:02 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 85174 invoked by uid 99); 30 Jun 2017 17:17:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 Jun 2017 17:17:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id B43AF18193B for ; Fri, 30 Jun 2017 17:17:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id azZ8EOci3kpd for ; Fri, 30 Jun 2017 17:17:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id D218D5F2FD for ; Fri, 30 Jun 2017 17:17:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6E869E0026 for ; Fri, 30 Jun 2017 17:17:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2C168245C1 for ; Fri, 30 Jun 2017 17:17:00 +0000 (UTC) Date: Fri, 30 Jun 2017 17:17:00 +0000 (UTC) From: "Mike Drob (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HBASE-18303) Clean up some parameterized test declarations MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 30 Jun 2017 17:17:03 -0000 [ https://issues.apache.org/jira/browse/HBASE-18303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-18303: ------------------------------ Attachment: HBASE-18303.patch v1: * Moves some common parameter types from hbase-server to hbase-common * Switches parameterized tests to use those types where possible * Switches from constructor form to @Parameter annotation Intentionally does not address changes in hbase-server so that any failures in that module are known to be unrelated. Precommit will run in hbase-server because I moved code out of {{HBaseTestingUtility}} > Clean up some parameterized test declarations > --------------------------------------------- > > Key: HBASE-18303 > URL: https://issues.apache.org/jira/browse/HBASE-18303 > Project: HBase > Issue Type: Improvement > Components: test > Reporter: Mike Drob > Assignee: Mike Drob > Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-18303.patch > > > While debugging something unrelated, I noticed that we use the constructor form of junit parameterized tests, instead of the annotated members form. > I personally find using the @Parameter annotation more clear. > Also, we can move the parameter generator to hbase-common so that it is accessible in more modules. -- This message was sent by Atlassian JIRA (v6.4.14#64029)