Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 290D0200CC4 for ; Thu, 29 Jun 2017 00:22:04 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 27FF5160BF7; Wed, 28 Jun 2017 22:22:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6CE90160BFA for ; Thu, 29 Jun 2017 00:22:03 +0200 (CEST) Received: (qmail 15730 invoked by uid 500); 28 Jun 2017 22:22:02 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 15719 invoked by uid 99); 28 Jun 2017 22:22:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Jun 2017 22:22:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 08B9E180311 for ; Wed, 28 Jun 2017 22:22:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 0gKfrid10ggE for ; Wed, 28 Jun 2017 22:22:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id DEC265FD53 for ; Wed, 28 Jun 2017 22:22:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 64E12E0BC8 for ; Wed, 28 Jun 2017 22:22:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1D94724161 for ; Wed, 28 Jun 2017 22:22:00 +0000 (UTC) Date: Wed, 28 Jun 2017 22:22:00 +0000 (UTC) From: "Mike Drob (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-18290) Fix TestAddColumnFamilyProcedure and TestDeleteTableProcedure MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 28 Jun 2017 22:22:04 -0000 [ https://issues.apache.org/jira/browse/HBASE-18290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16067356#comment-16067356 ] Mike Drob commented on HBASE-18290: ----------------------------------- Do you think this is also the root behind TestRegionObserverInterface flakiness? All the errors there are during {noformat} org.junit.runners.model.TestTimedOutException: test timed out after 300000 milliseconds at java.lang.Thread.sleep(Native Method) at org.apache.hadoop.hbase.client.HBaseAdmin$ProcedureFuture.waitProcedureResult(HBaseAdmin.java:3409) at org.apache.hadoop.hbase.client.HBaseAdmin$ProcedureFuture.get(HBaseAdmin.java:3339) at org.apache.hadoop.hbase.client.HBaseAdmin.get(HBaseAdmin.java:1962) at org.apache.hadoop.hbase.client.HBaseAdmin.deleteTable(HBaseAdmin.java:558) at org.apache.hadoop.hbase.HBaseTestingUtility.deleteTable(HBaseTestingUtility.java:1747) at org.apache.hadoop.hbase.coprocessor.TestRegionObserverInterface.testRecovery(TestRegionObserverInterface.java:616) {noformat} or because it is a timeout it might be a different failure? > Fix TestAddColumnFamilyProcedure and TestDeleteTableProcedure > ------------------------------------------------------------- > > Key: HBASE-18290 > URL: https://issues.apache.org/jira/browse/HBASE-18290 > Project: HBase > Issue Type: Bug > Components: test > Affects Versions: 2.0.0 > Reporter: stack > Assignee: stack > Fix For: 2.0.0 > > > These two tests don't pass. Turns out the cause was interesting. > We added a workaround for case where procedure WAL could have procs out of order. > HBASE-18216 [AMv2] Workaround for HBASE-18152, corrupt procedure WAL > If we find a procedure that is not 'increasing' -- of a later timestamp or procid -- then we'd skip the application of the 'old' proc. The workaround was until we figure in what scenarios we can write procedures out of order (seems to be rare and high-concurrency... TBD). > These two tests trip FAILs and ROLLBACKs (double delete of table or disable of an already disabled table). They are good tests. But procedures that get marked FAIL or ROLLEDBACK will have procids that are less than current. Makes it so we skipped adding the ROLLBACK and so finishing up the procedure. -- This message was sent by Atlassian JIRA (v6.4.14#64029)