Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 28 Jun 2017 03:48:02 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13082810.1498568604000.121054.1498621682617@Atlassian.JIRA>
In-Reply-To: <JIRA.13082810.1498568604000@Atlassian.JIRA>
References: <JIRA.13082810.1498568604000@Atlassian.JIRA> <JIRA.13082810.1498568604597@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HBASE-18273) hbase_rotate_log in
 hbase-daemon.sh script not working for some JDK
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 28 Jun 2017 03:48:09 -0000


    [ https://issues.apache.org/jira/browse/HBASE-18273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16065882#comment-16065882 ] 

Hadoop QA commented on HBASE-18273:
-----------------------------------

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m  8s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue}  0m  4s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green}  0m  3s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 28m 49s{color} | {color:green} Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha3. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 14s{color} | {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 29m 26s{color} | {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:757bf37 |
| JIRA Issue | HBASE-18273 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12874799/HBASE-18273.2.patch |
| Optional Tests |  asflicense  shellcheck  shelldocs  |
| uname | Linux 3b078ec6d7d8 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh |
| git revision | master / b313043 |
| shellcheck | v0.4.6 |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/7372/console |
| Powered by | Apache Yetus 0.4.0   http://yetus.apache.org |


This message was automatically generated.


> hbase_rotate_log in hbase-daemon.sh script not working for some JDK
> -------------------------------------------------------------------
>
>                 Key: HBASE-18273
>                 URL: https://issues.apache.org/jira/browse/HBASE-18273
>             Project: HBase
>          Issue Type: Bug
>          Components: hbase
>    Affects Versions: 1.2.6, 1.1.11, 2.0.0-alpha-1
>            Reporter: Fangyuan Deng
>            Assignee: Fangyuan Deng
>             Fix For: 2.0.0-beta-2
>
>         Attachments: HBASE-18273.0.patch, HBASE-18273.1.patch, HBASE-18273.2.patch
>
>
> When restarting a hbase process,  hbase_rotate_log $HBASE_LOGGC will rotate GC logs.
> the code looks like this,
>  if [ -f "$log" ]; then # rotate logs
>     while [ $num -gt 1 ]; do
>         prev=`expr $num - 1`
>         [ -f "$log.$prev" ] && mv -f "$log.$prev" "$log.$num"
>         num=$prev
>     done
> But, some version JDK will add a suffix (.0) to the gc file, like hbase-xxx.gc.0,  rather than hbase-xxx.gc.
> So I add a check before rotate,
>  if [ ! -f "$log" ]; then #for some jdk, gc log has a postfix 0
>       if [ -f "$log.0" ]; then
>         mv -f "$log.0" "$log";
>       fi
>     fi


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)