Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4B045200CA9 for ; Fri, 16 Jun 2017 21:33:08 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 49977160BEB; Fri, 16 Jun 2017 19:33:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8FB2F160BC0 for ; Fri, 16 Jun 2017 21:33:07 +0200 (CEST) Received: (qmail 52798 invoked by uid 500); 16 Jun 2017 19:33:06 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 52787 invoked by uid 99); 16 Jun 2017 19:33:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 Jun 2017 19:33:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 36ABAC0E1F for ; Fri, 16 Jun 2017 19:33:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id RNdUqYjhHweK for ; Fri, 16 Jun 2017 19:33:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 972425FC3A for ; Fri, 16 Jun 2017 19:33:04 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D62CEE0D51 for ; Fri, 16 Jun 2017 19:33:02 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id C118124002 for ; Fri, 16 Jun 2017 19:33:00 +0000 (UTC) Date: Fri, 16 Jun 2017 19:33:00 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-18225) Fix findbugs regression calling toString() on an array MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 16 Jun 2017 19:33:08 -0000 [ https://issues.apache.org/jira/browse/HBASE-18225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16052310#comment-16052310 ] Hudson commented on HBASE-18225: -------------------------------- FAILURE: Integrated in Jenkins build HBase-2.0 #54 (See [https://builds.apache.org/job/HBase-2.0/54/]) HBASE-18225 Avoid toString() on an array (elserj: rev 2ef80ab39a974303f80dbedafcbf124121241d1a) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java > Fix findbugs regression calling toString() on an array > ------------------------------------------------------ > > Key: HBASE-18225 > URL: https://issues.apache.org/jira/browse/HBASE-18225 > Project: HBase > Issue Type: Bug > Reporter: Josh Elser > Assignee: Josh Elser > Priority: Trivial > Fix For: 2.0.0, 3.0.0 > > Attachments: HBASE-18225.001.patch > > > Looks like we got a findbugs warning as a result of HBASE-18166 > {code} > diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java > index 1d04944250..b7e0244aa2 100644 > --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java > +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java > @@ -2807,8 +2807,8 @@ public class RSRpcServices implements HBaseRPCErrorHandler, > HRegionInfo hri = rsh.s.getRegionInfo(); > // Yes, should be the same instance > if (regionServer.getOnlineRegion(hri.getRegionName()) != rsh.r) { > - String msg = "Region was re-opened after the scanner" + scannerName + " was created: " > - + hri.getRegionNameAsString(); > + String msg = "Region has changed on the scanner " + scannerName + ": regionName=" > + + hri.getRegionName() + ", scannerRegionName=" + rsh.r; > {code} > Looks like {{hri.getRegionNameAsString()}} was unintentionally changed to {{hri.getRegionName()}}, [~syuanjiang]/[~stack]? -- This message was sent by Atlassian JIRA (v6.4.14#64029)