Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 14 Jun 2017 04:48:00 +0000 (UTC)
From: "chenxu (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13079644.1497415008000.14324.1497415680042@Atlassian.JIRA>
In-Reply-To: <JIRA.13079644.1497415008000@Atlassian.JIRA>
References: <JIRA.13079644.1497415008000@Atlassian.JIRA> <JIRA.13079644.1497415008071@jira-lw-us.apache.org>
Subject: [jira] [Updated] (HBASE-18215) some advises about refactoring of
 rsgroup
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Wed, 14 Jun 2017 04:48:04 -0000


     [ https://issues.apache.org/jira/browse/HBASE-18215?page=3Dcom.atlassi=
an.jira.plugin.system.issuetabpanels:all-tabpanel ]

chenxu updated HBASE-18215:
---------------------------
    Attachment: HBASE-18215-1.2.4-v1.patch

here is the patch about our implementation.

> some advises about refactoring of rsgroup
> -----------------------------------------
>
>                 Key: HBASE-18215
>                 URL: https://issues.apache.org/jira/browse/HBASE-18215
>             Project: HBase
>          Issue Type: Improvement
>          Components: Balancer
>            Reporter: chenxu
>         Attachments: HBASE-18215-1.2.4-v1.patch
>
>
> recently we have Integrated rsgroup into our cluster,  after Integrated, =
found some refactoring points. maybe the points were not right, but i think=
 there is a need to share with you guys.
> # when hbase.balancer.tablesOnMaster configured, RSGroupBasedLoadBalancer=
 should consider masterServer assignment first in balanceCluster, roundRobi=
nAssignment, retainAssignment and randomAssignment
>   do the same thing as BaseLoadBalancer
> # why not use a local file as the persistence layer instead of rsgroup ta=
ble.=20
> in our implementation, we first modify the local rsgroup file, then load =
the group info into memory, after that execute the balancer command, everyt=
hing is OK.
> when loading do some sanity check:
> (1) one server can not be owned by multi group
> (2) one table can not be owned by multi group
> (3) if group has table, it must also has servers
> (4) default group must has servers in it
> if sanity check can=E2=80=99t pass, give up the following process.work as=
 this, it can greatly reduce the complexity of rsgroup implementation, ther=
e is no need to wait for the rsgroup table to be online, and methods like m=
oveServers, moveTables, addRSGroup, removeRSGroup, moveServersAndTables can=
 be removed from RSGroupAdminService.only a refresh method is need(modify p=
ersistence layer first and refresh the memory)
> # we should add some group informations on master web UI
> to do this, RSGroupBasedLoadBalancer should move to hbase-server module, =
because MasterStatusTmpl.jamon depends on it
> # there may be some issues about RSGroupBasedLoadBalancer.roundRobinAssig=
nment
> if two groups both include BOGUS_SERVER_NAME, assignments.putAll will ove=
rwrite the previous data
> # there may be some issues about RSGroupBasedLoadBalancer.randomAssignmen=
t
> when the return value is BOGUS_SERVER_NAME, AM can not handle this case. =
we should return null value instead of BOGUS_SERVER_NAME.
> # when RSGroupBasedLoadBalancer.balanceCluster execute, groups are balanc=
ed one by one, if there are two many groups, we can do this in parallel.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)