Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E96B3200CAA for ; Sat, 17 Jun 2017 08:25:05 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id E7F37160BD1; Sat, 17 Jun 2017 06:25:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 3AD2C160BCD for ; Sat, 17 Jun 2017 08:25:05 +0200 (CEST) Received: (qmail 84487 invoked by uid 500); 17 Jun 2017 06:25:04 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 84476 invoked by uid 99); 17 Jun 2017 06:25:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 17 Jun 2017 06:25:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 029F8C0260 for ; Sat, 17 Jun 2017 06:25:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.211 X-Spam-Level: X-Spam-Status: No, score=-99.211 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id rOOGdmrgGaoC for ; Sat, 17 Jun 2017 06:25:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id C2CFE5F6D3 for ; Sat, 17 Jun 2017 06:25:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 66948E07D6 for ; Sat, 17 Jun 2017 06:25:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2B3C724005 for ; Sat, 17 Jun 2017 06:25:00 +0000 (UTC) Date: Sat, 17 Jun 2017 06:25:00 +0000 (UTC) From: "Guanghao Zhang (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-18170) Refactor ReplicationSourceWALReaderThread MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sat, 17 Jun 2017 06:25:06 -0000 [ https://issues.apache.org/jira/browse/HBASE-18170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16052716#comment-16052716 ] Guanghao Zhang commented on HBASE-18170: ---------------------------------------- Attach a 005 patch which addressed [~stack]'s comments. bq. no need of the Thread suffix I'd say Great. Remove it in 005 patch. Thanks. > Refactor ReplicationSourceWALReaderThread > ----------------------------------------- > > Key: HBASE-18170 > URL: https://issues.apache.org/jira/browse/HBASE-18170 > Project: HBase > Issue Type: Improvement > Reporter: Guanghao Zhang > Assignee: Guanghao Zhang > Attachments: HBASE-18170.master.001.patch, HBASE-18170.master.001.patch, HBASE-18170.master.002.patch, HBASE-18170.master.002.patch, HBASE-18170.master.003.patch, HBASE-18170.master.004.patch, HBASE-18170.master.005.patch > > > HBASE-18130 add some get* method to ReplicationSource. So ReplicationSourceWALReaderThread doesn't need so many parameter to initialize. And the WALEntryFilter only used by ReplicationSourceWALReaderThread, so we don't need to new it for every ReplicationSourceWALReaderThread. Meanwhile, we can separate a new RecoveredReplicationSourceWALReaderThread for recovered replication source. Thanks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)