Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B06C5200CAD for ; Tue, 6 Jun 2017 07:23:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id AF47E160BE1; Tue, 6 Jun 2017 05:23:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 024EF160BD4 for ; Tue, 6 Jun 2017 07:23:21 +0200 (CEST) Received: (qmail 86683 invoked by uid 500); 6 Jun 2017 05:23:20 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 86671 invoked by uid 99); 6 Jun 2017 05:23:20 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Jun 2017 05:23:20 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 676271A033B for ; Tue, 6 Jun 2017 05:23:20 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id vNFr5n1KXZrg for ; Tue, 6 Jun 2017 05:23:19 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 632CA5FBC5 for ; Tue, 6 Jun 2017 05:23:19 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id CECBCE0C0D for ; Tue, 6 Jun 2017 05:23:18 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2B50E21E0F for ; Tue, 6 Jun 2017 05:23:18 +0000 (UTC) Date: Tue, 6 Jun 2017 05:23:18 +0000 (UTC) From: "stack (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HBASE-18166) [AMv2] We are splitting already-split files MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 06 Jun 2017 05:23:22 -0000 [ https://issues.apache.org/jira/browse/HBASE-18166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18166: -------------------------- Attachment: HBASE-18166.master.002.patch > [AMv2] We are splitting already-split files > ------------------------------------------- > > Key: HBASE-18166 > URL: https://issues.apache.org/jira/browse/HBASE-18166 > Project: HBase > Issue Type: Bug > Components: Region Assignment > Affects Versions: 2.0.0 > Reporter: stack > Assignee: stack > Fix For: 2.0.0 > > Attachments: HBASE-18166.master.001.patch, HBASE-18166.master.002.patch > > > Interesting issue. The below adds a lag cleaning up files after a compaction in case of on-going Scanners (for read replicas/offheap). > HBASE-14970 Backport HBASE-13082 and its sub-jira to branch-1 - recommit (Ram) > What the lag means is that now that split is run from the HMaster in master branch, when it goes to get a listing of the files to split, it can pick up files that are for archiving but that have not been archived yet. When it does, it goes ahead and splits them... making references of references. > Its a mess. > I added asking the Region if it is splittable a while back. The Master calls this from SplitTableRegionProcedure during preparation. If the RegionServer asked for the split, it is sort of redundant work given the RS asks itself if any references still; if any, it'll wait before asking for a split. But if a user/client asks, then this isSplittable over RPC comes in handy. > I was thinking that isSplittable could return list of files.... > Or, easier, given we know a region is Splittable by the time we go to split the files, then I think master-side we can just skip any references found presuming read-for-archive. > Will be back with a patch. Want to test on cluster first (Side-effect is regions are offline because file at end of the reference to a reference is removed ... and so the open fails). -- This message was sent by Atlassian JIRA (v6.3.15#6346)