Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 5 Jun 2017 09:44:04 +0000 (UTC)
From: "Zheng Hu (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13077200.1496655742000.363850.1496655844125@Atlassian.JIRA>
In-Reply-To: <JIRA.13077200.1496655742000@Atlassian.JIRA>
References: <JIRA.13077200.1496655742000@Atlassian.JIRA> <JIRA.13077200.1496655742868@jira-lw-us.apache.org>
Subject: [jira] [Updated] (HBASE-18160) Fix incorrect  logic in
 FilterList.filterKeyValue
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 05 Jun 2017 09:44:09 -0000


     [ https://issues.apache.org/jira/browse/HBASE-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zheng Hu updated HBASE-18160:
-----------------------------
    Description: 
As HBASE-17678 said, there are two problems in FilterList.filterKeyValue implementation: 

1.  FilterList did not consider INCLUDE_AND_SEEK_NEXT_ROW case( seems like INCLUDE_AND_SEEK_NEXT_ROW is a newly added case, and the dev forgot to consider FilterList), So if a user use INCLUDE_AND_SEEK_NEXT_ROW in his own Filter and wrapped by a FilterList,  it'll  throw  an IllegalStateException("Received code is not valid."). 

2.  For FilterList with MUST_PASS_ONE,   if filter-A in filter list return  INCLUDE and filter-B in filter list return INCLUDE_AND_NEXT_COL,   the FilterList will return  INCLUDE_AND_NEXT_COL finally.  According to the mininal step rule , It's incorrect.  (filter list with MUST_PASS_ONE choose the mininal step among filters in filter list. Let's call it: The Mininal Step Rule).


  was:
As HBASE-17678 said, there are two problems in FilterList.filterKeyValue implementation: 

1.  FilterList did not consider INCLUDE_AND_SEEK_NEXT_ROW case( seems like INCLUDE_AND_SEEK_NEXT_ROW is a newly added case, and the dev forgot to consider FilterList), So if users use INCLUDE_AND_SEEK_NEXT_ROW in his own Filter and wrapped by a FilterList,  it'll  throw  an IllegalStateException("Received code is not valid."). 

2.  For FilterList with MUST_PASS_ONE,   if filter-A in filter list return  INCLUDE and filter-B in filter list return INCLUDE_AND_NEXT_COL,   the FilterList will return  INCLUDE_AND_NEXT_COL finally.  According to the mininal step rule , It's incorrect.  (filter list with MUST_PASS_ONE choose the mininal step among filters in filter list. Let's call it: The Mininal Step Rule).


> Fix incorrect  logic in FilterList.filterKeyValue
> -------------------------------------------------
>
>                 Key: HBASE-18160
>                 URL: https://issues.apache.org/jira/browse/HBASE-18160
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Zheng Hu
>            Assignee: Zheng Hu
>
> As HBASE-17678 said, there are two problems in FilterList.filterKeyValue implementation: 
> 1.  FilterList did not consider INCLUDE_AND_SEEK_NEXT_ROW case( seems like INCLUDE_AND_SEEK_NEXT_ROW is a newly added case, and the dev forgot to consider FilterList), So if a user use INCLUDE_AND_SEEK_NEXT_ROW in his own Filter and wrapped by a FilterList,  it'll  throw  an IllegalStateException("Received code is not valid."). 
> 2.  For FilterList with MUST_PASS_ONE,   if filter-A in filter list return  INCLUDE and filter-B in filter list return INCLUDE_AND_NEXT_COL,   the FilterList will return  INCLUDE_AND_NEXT_COL finally.  According to the mininal step rule , It's incorrect.  (filter list with MUST_PASS_ONE choose the mininal step among filters in filter list. Let's call it: The Mininal Step Rule).


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)