Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Sun, 4 Jun 2017 14:26:04 +0000 (UTC)
From: "Ted Yu (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13077127.1496569784000.361087.1496586364069@Atlassian.JIRA>
In-Reply-To: <JIRA.13077127.1496569784000@Atlassian.JIRA>
References: <JIRA.13077127.1496569784000@Atlassian.JIRA> <JIRA.13077127.1496569784252@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HBASE-18156) Provide a tool to show cache
 summary
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sun, 04 Jun 2017 14:26:09 -0000


    [ https://issues.apache.org/jira/browse/HBASE-18156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036292#comment-16036292 ] 

Ted Yu commented on HBASE-18156:
--------------------------------

Remove year in the header of new classes.

Add audience annotation for BlockCacheColumnFamilySummary.
{code}
93	   * @return blocks in the cache
{code}
blocks -> number of blocks

For equals() method, if you don't want to use curly braces, move the return to the end of if () line.
{code}
198	   * hdfs://localhost:51169/user/userid/-ROOT-/70236052/info/3944417774205889744
{code}
There is no root table any more - use a different table.

Should BlockCacheColumnFamilySummary be named ColumnFamilySummary ?
{code}
217	    BlockCacheColumnFamilySummary bcse = null;
{code}
Make variable name better reflect class name.
{code}
240	   * @return new BlockCacheSummaryEntry
{code}
Looks like BlockCacheSummaryEntry was the former name of the class. There're 6 occurrences of BlockCacheSummaryEntry - please correct them.

Add audience annotation for BlockCacheSizeDistributionSummary.


> Provide a tool to show cache summary
> ------------------------------------
>
>                 Key: HBASE-18156
>                 URL: https://issues.apache.org/jira/browse/HBASE-18156
>             Project: HBase
>          Issue Type: New Feature
>    Affects Versions: 2.0.0, 1.4.0
>            Reporter: Allan Yang
>            Assignee: Allan Yang
>         Attachments: HBASE-18156.patch
>
>
> HBASE-17757 is already committed. But since there is no easy way to show the size distribution of cached blocks, it is hard to decide the unified size should be used. 
> Here I provide a tool to show the details of size distribution of cached blocks. This tool is well used in our production environment. It is a jsp page summaries the cache details like this 
> {code}
> BlockCache type:org.apache.hadoop.hbase.io.hfile.LruBlockCache
> LruBlockCache
> Total size:28.40 GB
> Current size:22.49 GB
> MetaBlock size:1.56 GB
> Free size:5.91 GB
> Block count:152684
> Size distribution summary:
> BlockCacheSizeDistributionSummary [0 B<=blocksize<4 KB, blocks=833, heapSize=1.19 MB]
> BlockCacheSizeDistributionSummary [4 KB<=blocksize<8 KB, blocks=65, heapSize=310.83 KB]
> BlockCacheSizeDistributionSummary [8 KB<=blocksize<12 KB, blocks=175, heapSize=1.46 MB]
> BlockCacheSizeDistributionSummary [12 KB<=blocksize<16 KB, blocks=18, heapSize=267.43 KB]
> BlockCacheSizeDistributionSummary [16 KB<=blocksize<20 KB, blocks=512, heapSize=8.30 MB]
> BlockCacheSizeDistributionSummary [20 KB<=blocksize<24 KB, blocks=22, heapSize=499.66 KB]
> BlockCacheSizeDistributionSummary [24 KB<=blocksize<28 KB, blocks=24, heapSize=632.59 KB]
> BlockCacheSizeDistributionSummary [28 KB<=blocksize<32 KB, blocks=34, heapSize=1.02 MB]
> BlockCacheSizeDistributionSummary [32 KB<=blocksize<36 KB, blocks=31, heapSize=1.02 MB]
> BlockCacheSizeDistributionSummary [36 KB<=blocksize<40 KB, blocks=22, heapSize=838.58 KB]
> BlockCacheSizeDistributionSummary [40 KB<=blocksize<44 KB, blocks=28, heapSize=1.15 MB]
> {code}


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)