Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Sun, 4 Jun 2017 09:44:04 +0000 (UTC)
From: "Ted Yu (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13075816.1496147262000.360817.1496569444148@Atlassian.JIRA>
In-Reply-To: <JIRA.13075816.1496147262000@Atlassian.JIRA>
References: <JIRA.13075816.1496147262000@Atlassian.JIRA> <JIRA.13075816.1496147262870@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HBASE-18132) Low replication should be checked
 in period in case of datanode rolling upgrade
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sun, 04 Jun 2017 09:44:09 -0000


    [ https://issues.apache.org/jira/browse/HBASE-18132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036230#comment-16036230 ] 

Ted Yu commented on HBASE-18132:
--------------------------------

Lgtm

> Low replication should be checked in period in case of datanode rolling upgrade
> -------------------------------------------------------------------------------
>
>                 Key: HBASE-18132
>                 URL: https://issues.apache.org/jira/browse/HBASE-18132
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 1.4.0, 1.1.10
>            Reporter: Allan Yang
>            Assignee: Allan Yang
>         Attachments: HBASE-18132-branch-1.patch, HBASE-18132-branch-1.v2.patch, HBASE-18132-branch-1.v3.patch, HBASE-18132-branch-1.v4.patch, HBASE-18132.patch
>
>
> For now, we just check low replication of WALs when there is a sync operation (HBASE-2234), rolling the log if the replica of the WAL is less than configured. But if the WAL has very little writes or no writes at all, low replication will not be detected and thus no log will be rolled. 
> That is a problem when rolling updating datanode, all replica of the WAL with no writes will be restarted and lead to the WAL file end up with a abnormal state. Later operation of opening this file will be always failed.
> I bring up a patch to check low replication of WALs at a configured period. When rolling updating datanodes, we just make sure the restart interval time between two nodes is bigger than the low replication check time, the WAL will be closed and rolled normally. A UT in the patch will show everything.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)