Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 985F0200CB5 for ; Wed, 7 Jun 2017 07:55:24 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 971DE160BC6; Wed, 7 Jun 2017 05:55:24 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E4E9F160BD3 for ; Wed, 7 Jun 2017 07:55:23 +0200 (CEST) Received: (qmail 75107 invoked by uid 500); 7 Jun 2017 05:55:23 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 74965 invoked by uid 99); 7 Jun 2017 05:55:22 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Jun 2017 05:55:22 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 6982DC08B5 for ; Wed, 7 Jun 2017 05:55:22 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id dlAKtZw3ZfIB for ; Wed, 7 Jun 2017 05:55:21 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id BE63D60CD8 for ; Wed, 7 Jun 2017 05:55:19 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 0C3C7E0DA7 for ; Wed, 7 Jun 2017 05:55:19 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 652C821E12 for ; Wed, 7 Jun 2017 05:55:18 +0000 (UTC) Date: Wed, 7 Jun 2017 05:55:18 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-18132) Low replication should be checked in period in case of datanode rolling upgrade MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 07 Jun 2017 05:55:24 -0000 [ https://issues.apache.org/jira/browse/HBASE-18132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16040240#comment-16040240 ] Hudson commented on HBASE-18132: -------------------------------- SUCCESS: Integrated in Jenkins build HBase-1.3-JDK7 #177 (See [https://builds.apache.org/job/HBase-1.3-JDK7/177/]) HBASE-18132 Low replication should be checked in period in case of (apurtell: rev 69deecb1e4cc81f32878c528e63af0b742bdb735) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/LogRoller.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java * (add) hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestWALOpenAfterDNRollingStart.java > Low replication should be checked in period in case of datanode rolling upgrade > ------------------------------------------------------------------------------- > > Key: HBASE-18132 > URL: https://issues.apache.org/jira/browse/HBASE-18132 > Project: HBase > Issue Type: Bug > Affects Versions: 1.4.0, 1.1.10 > Reporter: Allan Yang > Assignee: Allan Yang > Fix For: 2.0.0, 1.4.0, 1.2.6, 1.3.2 > > Attachments: HBASE-18132-branch-1.patch, HBASE-18132-branch-1.v2.patch, HBASE-18132-branch-1.v3.patch, HBASE-18132-branch-1.v4.patch, HBASE-18132.patch > > > For now, we just check low replication of WALs when there is a sync operation (HBASE-2234), rolling the log if the replica of the WAL is less than configured. But if the WAL has very little writes or no writes at all, low replication will not be detected and thus no log will be rolled. > That is a problem when rolling updating datanode, all replica of the WAL with no writes will be restarted and lead to the WAL file end up with a abnormal state. Later operation of opening this file will be always failed. > I bring up a patch to check low replication of WALs at a configured period. When rolling updating datanodes, we just make sure the restart interval time between two nodes is bigger than the low replication check time, the WAL will be closed and rolled normally. A UT in the patch will show everything. -- This message was sent by Atlassian JIRA (v6.3.15#6346)