Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 6 Jun 2017 00:55:12 +0000 (UTC)
From: "Ted Yu (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13063446.1491996145000.1204.1496710512097@Atlassian.JIRA>
In-Reply-To: <JIRA.13063446.1491996145000@Atlassian.JIRA>
References: <JIRA.13063446.1491996145000@Atlassian.JIRA> <JIRA.13063446.1491996145187@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HBASE-17907) [C++] End to end Scans from
 Client/Table
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 06 Jun 2017 00:55:16 -0000


    [ https://issues.apache.org/jira/browse/HBASE-17907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16037920#comment-16037920 ] 

Ted Yu commented on HBASE-17907:
--------------------------------

{code}
+std::string ScanControllerImpl::DebugString(ScanControllerState state) {
+std::string ScanControllerImpl::DebugString(ScanResumerState state) {
{code}
The above methods produce strings which seem to be identical for corresponding states in controller and consumer. Consider distinguishing the states with "controller" / "consumer".
{code}
+  VLOG(5) << "Scan: CompleteNoMoreResults";
{code}
Consider adding scanner_id, etc to the above log.
{code}
+void AsyncTableResultScanner::Close() {
+  std::unique_lock<std::mutex> mlock(mutex_);
+  closed_ = true;
+  while (!queue_.empty()) {
+    queue_.pop();
{code}
For the remaining elements in queue_, we can discard without further action ?


> [C++] End to end Scans from Client/Table
> ----------------------------------------
>
>                 Key: HBASE-17907
>                 URL: https://issues.apache.org/jira/browse/HBASE-17907
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>             Fix For: HBASE-14850
>
>         Attachments: hbase-17907-v1.patch, hbase-17907_v2.patch, hbase-scan-v0.patch
>
>
> Scan support from client, including the implementation for retrying RPCs, scanner management, scan result caching, prefetch, Client side interfaces and all related code. 


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)