Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 893AB200CA8 for ; Thu, 15 Jun 2017 15:22:06 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 87D77160BED; Thu, 15 Jun 2017 13:22:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id CF0EA160BDF for ; Thu, 15 Jun 2017 15:22:05 +0200 (CEST) Received: (qmail 1809 invoked by uid 500); 15 Jun 2017 13:22:05 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 1797 invoked by uid 99); 15 Jun 2017 13:22:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Jun 2017 13:22:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 7A2F01A03E8 for ; Thu, 15 Jun 2017 13:22:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id AoflBKtb_Jpv for ; Thu, 15 Jun 2017 13:22:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id AE4225F6CD for ; Thu, 15 Jun 2017 13:22:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6E356E0C0D for ; Thu, 15 Jun 2017 13:22:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 38FC421E0F for ; Thu, 15 Jun 2017 13:22:00 +0000 (UTC) Date: Thu, 15 Jun 2017 13:22:00 +0000 (UTC) From: "Jan Kunigk (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References:

Subject: [jira] [Commented] (HBASE-16415) Replication in different namespace MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 15 Jun 2017 13:22:06 -0000 [ https://issues.apache.org/jira/browse/HBASE-16415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16050466#comment-16050466 ] Jan Kunigk commented on HBASE-16415: ------------------------------------ Hi Guanghao, thanks for your feedback. Yes, I agree it would be better to use a new ReplicationEndpoint. The ReplicationEndpoint is passed into the run() method of ReplicaitonSource: ``` // get the WALEntryFilter from ReplicationEndpoint and add it to default filters ArrayList filters = Lists.newArrayList( (WALEntryFilter)new SystemTableWALEntryFilter()); WALEntryFilter filterFromEndpoint = this.replicationEndpoint.getWALEntryfilter(); ``` then at the end of this method a new attempt for starting the shipper thread (i.e. ReplicationSourceWALReaderThread) is launched: ``` tryStartNewShipperThread(walGroupId, queue); ``` tryStartNewShipperThread() is invoking startNewWALReaderThread, which returns a ReplicationSourceWALReaderThread and also applies all filters to it: ``` ChainWALEntryFilter readerFilter = new ChainWALEntryFilter(filters); ReplicationSourceWALReaderThread walReader = new ReplicationSourceWALReaderThread(manager, replicationQueueInfo, queue, startPosition, fs, conf, readerFilter, metrics); ``` I agree, that embedding the redirections information into a new ReplicationEndpoint just like we do with the filters makes sense. But, the inspection of the individual WAL entries would still have to occur in the Shipper Threads itself (like ``` entry = filterEntry(entry); entry = redirectEntry(entry); ``` ) Do you agree? Or am I missing something? > Replication in different namespace > ---------------------------------- > > Key: HBASE-16415 > URL: https://issues.apache.org/jira/browse/HBASE-16415 > Project: HBase > Issue Type: New Feature > Components: Replication > Reporter: Christian Guegi > Assignee: Jan Kunigk > > It would be nice to replicate tables from one namespace to another namespace. > Example: > Master cluster, namespace=default, table=bar > Slave cluster, namespace=dr, table=bar > Replication happens in class ReplicationSink: > public void replicateEntries(List entries, final CellScanner cells, ...){ > ... > TableName table = TableName.valueOf(entry.getKey().getTableName().toByteArray()); > ... > addToHashMultiMap(rowMap, table, clusterIds, m); > ... > for (Entry, List>> entry : rowMap.entrySet()) { > batch(entry.getKey(), entry.getValue().values()); > } > } -- This message was sent by Atlassian JIRA (v6.4.14#64029)