Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id CC9B6200C89 for ; Sat, 3 Jun 2017 10:26:11 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id C9FD2160BDE; Sat, 3 Jun 2017 08:26:11 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1B156160BBE for ; Sat, 3 Jun 2017 10:26:10 +0200 (CEST) Received: (qmail 68704 invoked by uid 500); 3 Jun 2017 08:26:09 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 68690 invoked by uid 99); 3 Jun 2017 08:26:09 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 03 Jun 2017 08:26:09 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id B315718838F for ; Sat, 3 Jun 2017 08:26:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id aJ5uZTFvDJeg for ; Sat, 3 Jun 2017 08:26:08 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 4C3605FE06 for ; Sat, 3 Jun 2017 08:26:07 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 4FB13E0D27 for ; Sat, 3 Jun 2017 08:26:06 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id ECC3921B5A for ; Sat, 3 Jun 2017 08:26:04 +0000 (UTC) Date: Sat, 3 Jun 2017 08:26:04 +0000 (UTC) From: "Yu Li (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-15160) Put back HFile's HDFS op latency sampling code and add metrics for monitoring MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sat, 03 Jun 2017 08:26:12 -0000 [ https://issues.apache.org/jira/browse/HBASE-15160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035892#comment-16035892 ] Yu Li commented on HBASE-15160: ------------------------------- Good findings [~yangzhe1991], the analysis makes sense, let's get HBASE-18151 fixed and recheck the perf of using nano. And thanks for all the efforts [~enis]. > Put back HFile's HDFS op latency sampling code and add metrics for monitoring > ----------------------------------------------------------------------------- > > Key: HBASE-15160 > URL: https://issues.apache.org/jira/browse/HBASE-15160 > Project: HBase > Issue Type: Sub-task > Affects Versions: 2.0.0, 1.1.2 > Reporter: Yu Li > Assignee: Yu Li > Priority: Critical > Attachments: HBASE-15160.patch, HBASE-15160_v2.patch, HBASE-15160_v3.patch, hbase-15160_v4.patch, hbase-15160_v5.patch, hbase-15160_v6.patch, hbase-15160_v7.patch, hbase-15160_v8.patch > > > In HBASE-11586 all HDFS op latency sampling code, including fsReadLatency, fsPreadLatency and fsWriteLatency, have been removed. There was some discussion about putting them back in a new JIRA but never happened. According to our experience, these metrics are useful to judge whether issue lies on HDFS when slow request occurs, so we propose to put them back in this JIRA, and add the metrics for monitoring as well. -- This message was sent by Atlassian JIRA (v6.3.15#6346)