hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18286) Create static empty byte array to save memory
Date Thu, 29 Jun 2017 17:17:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16068640#comment-16068640

stack commented on HBASE-18286:

Nice patch [~BenEpstein]. A bit of feedback: statics are UPPERCASE in our code base (this
is an old convention around java world) and there is an empty byte array up in HConstants
if you want to reuse it...   public static final byte [] EMPTY_BYTE_ARRAY = new byte [0];

Thanks sir.

> Create static empty byte array to save memory
> ---------------------------------------------
>                 Key: HBASE-18286
>                 URL: https://issues.apache.org/jira/browse/HBASE-18286
>             Project: HBase
>          Issue Type: Improvement
>          Components: community
>            Reporter: Ben Epstein
>            Assignee: Ben Epstein
>            Priority: Trivial
>         Attachments: 0001-created-a-static-zero-byte-array-to-save-memory.patch
>   Original Estimate: 5m
>  Remaining Estimate: 5m
> In Put.java, create a static empty byte array so new ones do not have to be allocated
every time it is passed into a function

This message was sent by Atlassian JIRA

View raw message