hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chia-Ping Tsai (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18266) Suppress the warnings from the spotbugs
Date Mon, 26 Jun 2017 10:12:01 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16062873#comment-16062873
] 

Chia-Ping Tsai commented on HBASE-18266:
----------------------------------------

{code:title=RegionCoprocessorHost.java|borderStyle=solid}
  public void postAppend(final Append append, final Result result) throws IOException {
    execOperation(coprocessors.isEmpty() ? null : new RegionOperation() {
      @Override
      public void call(RegionObserver oserver, ObserverContext<RegionCoprocessorEnvironment>
ctx)
          throws IOException {
        oserver.postAppend(ctx, append, result);
      }
    });
  }

  /**
   * @param increment increment object
   * @param result the result returned by postIncrement
   * @throws IOException if an error occurred on the coprocessor
   */
  public Result postIncrement(final Increment increment, Result result) throws IOException
{
    return execOperationWithResult(result,
        coprocessors.isEmpty() ? null : new RegionOperationWithResult<Result>() {
      @Override
      public void call(RegionObserver oserver, ObserverContext<RegionCoprocessorEnvironment>
ctx)
          throws IOException {
        setResult(oserver.postIncrement(ctx, increment, getResult()));
      }
    });
  }
{code}
Why do we ignore the Result from the oserver.postAppend? Will open another jira to discuss
it.

> Suppress the warnings from the spotbugs
> ---------------------------------------
>
>                 Key: HBASE-18266
>                 URL: https://issues.apache.org/jira/browse/HBASE-18266
>             Project: HBase
>          Issue Type: Task
>            Reporter: Chia-Ping Tsai
>             Fix For: 3.0.0, 1.4.0, 1.3.2, 1.2.7, 2.0.0-alpha-2, 1.1.12
>
>
> It is hard to get +1 from QA currently because spotbugs is always unhappy...



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message