hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Umesh Agashe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18235) LoadBalancer.BOGUS_SERVER_NAME should not have a bogus hostname
Date Mon, 19 Jun 2017 18:51:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16054579#comment-16054579
] 

Umesh Agashe commented on HBASE-18235:
--------------------------------------

{code}
   // Used to signal to the caller that the region(s) cannot be assigned
-  static final ServerName BOGUS_SERVER_NAME = ServerName.valueOf("bogus.example.com,1,1");
+  ServerName BOGUS_SERVER_NAME = ServerName.valueOf("bogus.example.com,1,1");
{code}

I did a cleanup while working on HBASE-17786. As the field is in interface static is redundant.
Removed static from the declaration. Change 'localhost' to 'bogus.example.com' happened with
patch for HBASE-17624, as [~toffer] has pointed out.

> LoadBalancer.BOGUS_SERVER_NAME should not have a bogus hostname
> ---------------------------------------------------------------
>
>                 Key: HBASE-18235
>                 URL: https://issues.apache.org/jira/browse/HBASE-18235
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Francis Liu
>            Assignee: Francis Liu
>
> The original patch used localhost to have assignment fail fast. Avoiding misleading DNS
exceptions, delays due to dns lookup, etc. 
> Was wondering what the reason was for changing it?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message