hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yu Li (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18233) We shouldn't wait for readlock in doMiniBatchMutation in case of deadlock
Date Mon, 19 Jun 2017 03:59:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16053457#comment-16053457
] 

Yu Li commented on HBASE-18233:
-------------------------------

Overall the patch lgtm. Good to have the new unit test case. Some minor comments:
{code}
+        if(waitForLock) {
+          throw new IOException("Timed out waiting for lock for row: " + rowKey);
+        } else {
+          return result;
+        }
{code}
Maybe return null directly in the else clause makes the logic clearer?

Please also check the failed UT case and confirm whether relative. Thanks.

> We shouldn't wait for readlock in doMiniBatchMutation in case of deadlock
> -------------------------------------------------------------------------
>
>                 Key: HBASE-18233
>                 URL: https://issues.apache.org/jira/browse/HBASE-18233
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 1.2.7
>            Reporter: Allan Yang
>            Assignee: Allan Yang
>         Attachments: HBASE-18233-branch-1.2.patch
>
>
> Please refer to the discuss in HBASE-18144
> https://issues.apache.org/jira/browse/HBASE-18144?focusedCommentId=16051701&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16051701



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message