hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stephen Yuan Jiang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18225) Fix findbugs regression calling toString() on an array
Date Fri, 16 Jun 2017 04:24:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16051356#comment-16051356
] 

Stephen Yuan Jiang commented on HBASE-18225:
--------------------------------------------

Looks good to me.  

> Fix findbugs regression calling toString() on an array
> ------------------------------------------------------
>
>                 Key: HBASE-18225
>                 URL: https://issues.apache.org/jira/browse/HBASE-18225
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>            Priority: Trivial
>             Fix For: 2.0.0, 3.0.0
>
>         Attachments: HBASE-18225.001.patch
>
>
> Looks like we got a findbugs warning as a result of HBASE-18166
> {code}
> diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
> index 1d04944250..b7e0244aa2 100644
> --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
> +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
> @@ -2807,8 +2807,8 @@ public class RSRpcServices implements HBaseRPCErrorHandler,
>      HRegionInfo hri = rsh.s.getRegionInfo();
>      // Yes, should be the same instance
>      if (regionServer.getOnlineRegion(hri.getRegionName()) != rsh.r) {
> -      String msg = "Region was re-opened after the scanner" + scannerName + " was created:
"
> -          + hri.getRegionNameAsString();
> +      String msg = "Region has changed on the scanner " + scannerName + ": regionName="
> +          + hri.getRegionName() + ", scannerRegionName=" + rsh.r;
> {code}
> Looks like {{hri.getRegionNameAsString()}} was unintentionally changed to {{hri.getRegionName()}},
[~syuanjiang]/[~stack]?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message