hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Enis Soztutar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18174) Implement Table#checkAndPut()
Date Fri, 09 Jun 2017 23:59:18 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045241#comment-16045241
] 

Enis Soztutar commented on HBASE-18174:
---------------------------------------

Thanks Ted. 
A nit, but you can use this convenience method: 
{code}
RequestConverter::SetRegion(region_name, pb_msg->mutable_region());
{code}
Please run format-patch.sh and address make lint errors if any. 
- You are not using the new method BoolFromMutateResponse. Do you need to use instead of the
lambda? 
Other than these, looks good. 

> Implement Table#checkAndPut()
> -----------------------------
>
>                 Key: HBASE-18174
>                 URL: https://issues.apache.org/jira/browse/HBASE-18174
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Ted Yu
>         Attachments: 18174.v10.txt, 18174.v11.txt, 18174.v12.txt, 18174.v1.txt, 18174.v7.lambda.txt,
18174.v9.txt
>
>
> This task is to implement Table#checkAndPut() method



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message