hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Enis Soztutar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18174) Implement Table#checkAndPut()
Date Fri, 09 Jun 2017 17:33:18 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16044737#comment-16044737
] 

Enis Soztutar commented on HBASE-18174:
---------------------------------------

- Can we do the version of checkAndPut that takes the compareOp? This version just delegates
to the one that uses equals. We can keep both overloaded versions. 
{code}
+  folly::Future<folly::Unit> CheckAndPut(const std::string &row, const std::string
&family,
+          const std::string &qualifier, const std::string &value, const hbase::Put
&put);
{code}
- This should be named {{CheckAndPutToMutateRequest}}, because we will also do CheckAndMutate,
CheckAndDelete, etc. 
{code}
RequestConverter::CheckToMutateRequest
{code}
- Maybe name this {{ProcessedFromMutateResponse}}. 
{code}
BoolFromMutateResponse
{code}
- These lines:
{code}
auto pb_msg = std::static_pointer_cast<hbase::pb::MutateRequest>(checkReq->req_msg());
+                  pb::RegionSpecifier *region_specifier = pb_msg->mutable_region();
+                  region_specifier->set_type(
+                          pb::RegionSpecifier_RegionSpecifierType::RegionSpecifier_RegionSpecifierType_REGION_NAME);
+                  region_specifier->set_value(region_name);
{code}
should go inside the CheckToMutateRequest, no? 


> Implement Table#checkAndPut()
> -----------------------------
>
>                 Key: HBASE-18174
>                 URL: https://issues.apache.org/jira/browse/HBASE-18174
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Ted Yu
>         Attachments: 18174.v1.txt, 18174.v7.lambda.txt, 18174.v9.txt
>
>
> This task is to implement Table#checkAndPut() method



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message