hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18170) Refactor ReplicationSourceWALReaderThread
Date Sat, 17 Jun 2017 05:08:01 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16052691#comment-16052691

stack commented on HBASE-18170:

I know you are following someone else's pattern which is good but ReplicationSourceWALReaderThread
is poor name for class.... no need of the Thread suffix I'd say..... but can change it and
ReplicationSourceWALReaderThread in a new issue.

85	    Threads.setDaemonThreadRunning(walReader, threadName
86	        + ".replicationSource.replicationWALReaderThread." + walGroupId + "," + peerClusterZnode,
87	      getUncaughtExceptionHandler());
88	    return walReader;

Could just return Threads.setDaemon.... The method returns the passed in 'thread'. Ditto for
later in the patch.

The above are nits.


> Refactor ReplicationSourceWALReaderThread
> -----------------------------------------
>                 Key: HBASE-18170
>                 URL: https://issues.apache.org/jira/browse/HBASE-18170
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Guanghao Zhang
>            Assignee: Guanghao Zhang
>         Attachments: HBASE-18170.master.001.patch, HBASE-18170.master.001.patch, HBASE-18170.master.002.patch,
HBASE-18170.master.002.patch, HBASE-18170.master.003.patch, HBASE-18170.master.004.patch
> HBASE-18130 add some get* method to ReplicationSource. So ReplicationSourceWALReaderThread
doesn't need so many parameter to initialize. And the WALEntryFilter only used by ReplicationSourceWALReaderThread,
so we don't need to new it for every ReplicationSourceWALReaderThread. Meanwhile, we can separate
a new RecoveredReplicationSourceWALReaderThread for recovered replication source. Thanks.

This message was sent by Atlassian JIRA

View raw message